-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEL parser tweaks + standardized AST nodes (to abstract ANTLR from users) #13
Open
dvdotsenko
wants to merge
32
commits into
master
Choose a base branch
from
sql-compat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CLASS NAMES CHANGED. Note, `TelVisitor` is now `TelParserVisitor` and `TelListener` is now `TelParserListener`
…icating settings
…t reality of having to accept lists of statements
…ed" properly This is different from raw_value which may have original text, spacing and different quotation. .value is pure synthetically-re-assembed taxon expression value
…d visit(node) style. More in-line with ANTLR way of doing things.
Reduces noise in the file, allows better reuse of visitor
mrknmc
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed:
pql_grammar.from_pql.ParseError: Unexpected "ilike" (positions 3 to 7) in fragment "a -->ilike<-- 'asdf'"
(SeeTelErrorListener
- allows init without need to pass input stream to it.Goals: